jsferner commented on a change in pull request #3931: NIFI-6872: support
download flow
URL: https://github.com/apache/nifi/pull/3931#discussion_r357753201
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/registry/flow/mapping/NiFiRegistryFlowMapper.java
##########
@@ -599,23 +635,35 @@ private BatchSize mapBatchSettings(final RemoteGroupPort
remotePort) {
return batchSize;
}
- public VersionedParameterContext mapParameterContext(final
ParameterContext context) {
- if (context == null) {
- return null;
- }
-
- final Set<VersionedParameter> parameters =
context.getParameters().values().stream()
- .map(this::mapParameter)
- .collect(Collectors.toSet());
+ public Collection<VersionedParameterContext> mapParameterContexts(final
ProcessGroup processGroup, final boolean mapDescendantVersionedFlows) {
Review comment:
Agreed, moving everything to a Map to begin with, as we discussed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services