szaszm commented on a change in pull request #708: MINIFICPP-1118 - MiNiFi C++
on Windows stops running in a secure env …
URL: https://github.com/apache/nifi-minifi-cpp/pull/708#discussion_r366276241
##########
File path: libminifi/src/io/tls/TLSSocket.cpp
##########
@@ -182,9 +187,19 @@ int16_t TLSSocket::initialize(bool blocking) {
setNonBlocking();
logger_->log_trace("Initializing TLSSocket %d", is_server);
int16_t ret = context_->initialize(is_server);
- Socket::initialize();
- if (!ret && listeners_ == 0) {
+ if (ret != 0) {
+ logger_->log_warn("Failed to initialize SSL context!");
+ return -1;
+ }
+
+ ret = Socket::initialize();
+ if (ret != 0) {
+ logger_->log_warn("Failed to initialise basic socket for TLS socket");
+ return -1;
Review comment:
`context_` is left initialized even if socket initialization has failed.
This is not changed behavior, but is it intended?
Speaking about suspicious behavior, `TLSSocket::logger_` will be `nullptr`
if the object is initialized via the move ctor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
