szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement
RocksDB controller service and component st…
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366301930
##########
File path: libminifi/include/core/ProcessContext.h
##########
@@ -193,6 +216,61 @@ class ProcessContext : public
controller::ControllerServiceLookup, public core::
return controller_service_provider_->getControllerServiceName(identifier);
}
+ static constexpr char const* DefaultStateManagerProviderName =
"defaultstatemanagerprovider";
Review comment:
This line reminds me of stereotypical enterprise codebases. We might have
too much abstraction here.
default- ok
state- stateless is generally better, but ok
manager- meaningless. Only suggests doing something, so it should probably
be a verb. Having a noun in place of a verb usually means trying to use a class
where a function would be better.
provider- again, a class instead of a function. This has a meaning though.
name- ok
I'm not saying that your code is bad, just that this is a red flag that
suggests a design mistake that may or may not be in your changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
