joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors URL: https://github.com/apache/nifi/pull/3917#issuecomment-576024125 Yep this looks pretty cool but definitely needs NOTICE file updates and possibly LICENSE. The smbj library itself appears to include a copyright line we need to carry into NOTICE like we have many examples of. Haven't checked transitive libs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services