yarox opened a new pull request #4008: NIFI-7060 Replace properties in 
nifi.properties by environment variables
URL: https://github.com/apache/nifi/pull/4008
 
 
   Makes it possible to replace properties set in `nifi.properties` using 
environment variables when launching from Docker.
   
   `start.sh` replaces some properties defined in `nifi.properties` with a set 
of environment variables.
   
   This adds some flexibility as the users are able to modify properties 
without touching the `nifi.properties` file but it can lead to some frustration 
when users think they can replace any property by defining an environment 
variable with the same name. Also, when users want to provide their own 
`nifi.properties` file as some properties will be overwritten.
   
   I believe we should only replace a property when there is an environment 
variable defined with the same name (we should use the same names that appear 
in the `nifi.properties` file in uppercase and replacing any `.` with `_`). 
Defaults should be taken from the `nifi.properties` file.
   
   This way users can replace the properties file with a custom one, choose to 
define environment variables, or both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to