arpadboda commented on a change in pull request #719: MINIFICPP-1133 - Rocksdb operation errors should cause exceptions ins… URL: https://github.com/apache/nifi-minifi-cpp/pull/719#discussion_r372350544
########## File path: extensions/rocksdb-repos/FlowFileRepository.h ########## @@ -168,6 +172,8 @@ class FlowFileRepository : public core::Repository, public std::enable_shared_fr private: + virtual bool ExecuteWithRetry(std::function<rocksdb::Status()> operation); Review comment: Fair, as it's private, it add no value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
