szaszm commented on a change in pull request #716: MINIFICPP-1127 - Provenance
repo performance should be improved
URL: https://github.com/apache/nifi-minifi-cpp/pull/716#discussion_r372356176
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -56,21 +55,13 @@ class ProvenanceRepository : public core::Repository,
public std::enable_shared_
db_ = NULL;
}
- // Destructor
- virtual ~ProvenanceRepository() {
- if (db_)
- delete db_;
- }
-
- virtual void flush();
+ virtual void printStats();
Review comment:
This new function is local to the class and doesn't need to be `virtual`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
