szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r376000406
########## File path: libminifi/src/io/win/ClientSocket.cpp ########## @@ -242,11 +237,17 @@ int16_t Socket::initialize() { hints.ai_protocol = 0; /* any protocol */ int errcode = getaddrinfo(requested_hostname_.c_str(), 0, &hints, &addr_info_); Review comment: done in ab3c3b4. Please excuse my confusion while writing the previous comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services