szaszm opened a new pull request #731: MINIFICPP-1096 fix BackTrace, OOB indexing, tests, appveyor reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/731 Squashed commit of the following: commit b0764d9ad83dee400a0a757578f92eb0d1f37e7e Author: Szász Márton <sza...@users.noreply.github.com> Date: Mon Feb 3 11:08:44 2020 +0100 Check unit test failure report on appveyor commit 8fc8f2a3336111947ab6228c6f05240ad743c91d Author: Marton Szasz <szasz...@gmail.com> Date: Fri Jan 31 16:15:15 2020 +0000 MINIFICPP-1096 Fix TailFileTests on windows TailFile only supports single character (line) delimiter, but Windows uses CRLF ("\r\n") line endings. Changed the tests to write the test file in binary mode to avoid LF -> CRLF conversion that breaks TailFile. We should consider adapting TailFile to support CRLF as it's standard on Windows. commit c4a1ee6714da534f8fdea96c960a86b2f8dbdcf2 Author: Marton Szasz <szasz...@gmail.com> Date: Wed Jan 29 14:48:40 2020 +0100 MINIFICPP-1096 fix BackTrace and OOB indexing issues in streams Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
