szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378225328
########## File path: libminifi/include/core/state/nodes/AgentInformation.h ########## @@ -623,18 +632,70 @@ class AgentManifest : public DeviceInformation { }; /** - * Purpose and Justification: Prints classes along with their properties for the current agent. + * This class is used for regular heartbeat without manifest + * A light weight heartbeat */ -class AgentInformation : public DeviceInformation, public AgentMonitor, public AgentIdentifier { +class AgentInformationWithoutManifest : public DeviceInformation, public AgentMonitor, public AgentIdentifier { Review comment: Public inheritance means is-a relationship. By looking at the names, this class fits none of its base classes. Use composition (preferred) or private inheritance for implemented-in-terms-of relationship. Couldn't this class become just a `serialize_agent_information_without_manifest(...)` free function? OOP is a toolbox, not an obligation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services