msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement 
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378537631
 
 

 ##########
 File path: libminifi/src/FlowController.cpp
 ##########
 @@ -931,6 +942,35 @@ int16_t 
FlowController::getMetricsNodes(std::vector<std::shared_ptr<state::respo
   return 0;
 }
 
+int16_t 
FlowController::getManifestNodes(std::vector<std::shared_ptr<state::response::ResponseNode>>&
 manifest_vector, uint16_t metricsClass) {
+    std::lock_guard<std::mutex> lock(metrics_mutex_);
+    (void)metricsClass;
 
 Review comment:
   Are you talking about the "metricsClass" variable there?
   If you are asking about the function, it returns manifest information needed 
while responding to DESCRIBE manifest.
   
   metricsClass has been removed from this function in the updated code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to