bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix
HTTPCallback freeze and refactor class
URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382657022
##########
File path: libminifi/include/utils/HTTPClient.h
##########
@@ -219,16 +232,15 @@ class HTTPRequestResponse {
}
if (len > size * nmemb)
len = size * nmemb;
- auto strr = std::string(ptr,len);
memcpy(data, ptr, len);
callback->pos += len;
callback->ptr->seek(callback->getPos());
return len;
}
- } else {
- return 0x10000000;
+ return 0;
Review comment:
Umm... it's not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
