bakaid commented on a change in pull request #742: MINIFICPP-1165
URL: https://github.com/apache/nifi-minifi-cpp/pull/742#discussion_r383357941
##########
File path:
extensions/standard-processors/tests/integration/SecureSocketGetTCPTest.cpp
##########
@@ -110,7 +110,7 @@ class SecureSocketTest : public IntegrationBase {
host = org::apache::nifi::minifi::io::Socket::getMyHostName();
}
server_socket_ =
std::make_shared<org::apache::nifi::minifi::io::TLSServerSocket>(socket_context,
host, std::stoi(hostAndPort.at(1)), 3);
- server_socket_->initialize();
+ assert(0 == server_socket_->initialize());
Review comment:
No it will not.
All integration tests depend on assert, that's why they `#undef NDEBUG`
before including assert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
