mattyb149 commented on a change in pull request #3977: NIFI-7007 Add update
functionality to the PutCassandraRecord processor.
URL: https://github.com/apache/nifi/pull/3977#discussion_r383381823
##########
File path:
nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraRecord.java
##########
@@ -394,11 +394,17 @@ private Long convertFieldObjectToLong(String name,
Object value) {
// Check that if the update method is set to increment or
decrement that the batch statement type is set to
// unlogged or counter (or USE_ATTR_TYPE, which we cannot check at
this point).
+ String updateMethod =
validationContext.getProperty(UPDATE_METHOD).getValue();
String batchStatementType =
validationContext.getProperty(BATCH_STATEMENT_TYPE).getValue();
- if (!Sets.newHashSet(COUNTER_TYPE.getValue(),
UNLOGGED_TYPE.getValue(),
BATCH_STATEMENT_TYPE_USE_ATTR_TYPE.getValue()).contains(batchStatementType)) {
Review comment:
Removing this causes a CheckStyle error for the unused import for Sets. I
can remove that while merging, but if I end up leaving another comment asking
for changes please change this too and run Maven with `-Pcontrib-check` for the
cassandra bundle to make sure the build will succeed, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
