alopresto commented on a change in pull request #4077: NIFI-5346 Introduces new PGP controller service and PGP processors. URL: https://github.com/apache/nifi/pull/4077#discussion_r384216871
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java ########## @@ -445,12 +445,27 @@ public void modifyAttributes(final FlowFile flowFile) { modifyAttributes(flowFile, null); } + @Override + public void modifyAttributes(final FlowFile flowFile, final long processingMills) { + modifyAttributes(flowFile, null, -1L); + verifyFlowFileKnown(flowFile); + } + @Override public void modifyAttributes(final FlowFile flowFile, final String details) { + modifyAttributes(flowFile, details, -1L); + verifyFlowFileKnown(flowFile); Review comment: Same comment as above; `modifyAttributes(flowFile, details, -1L);` should invoke the method on line 461, which calls `verifyFlowFileKnown(flowFile);` also. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services