arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385202159
##########
File path: extensions/coap/tests/CoapIntegrationBase.h
##########
@@ -41,13 +41,13 @@ class CoapIntegrationBase : public IntegrationBase {
void setUrl(std::string url, CivetHandler *handler);
- virtual ~CoapIntegrationBase();
+ virtual ~CoapIntegrationBase() = default;
void shutdownBeforeFlowController() override {
stop_webserver(server);
}
- virtual void run(std::string test_file_location) override {
Review comment:
Why did you remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
