bakaid commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r385242227
##########
File path: libminifi/include/utils/BackTrace.h
##########
@@ -41,20 +42,16 @@ class TraceResolver;
*/
class BackTrace {
public:
- BackTrace() {
- }
- BackTrace(const std::string &name)
- : name_(name) {
+ BackTrace() = default;
+
+ explicit BackTrace(std::string name)
+ : name_(std::move(name)) {
}
- BackTrace(BackTrace &&) = default;
- BackTrace(BackTrace &) = delete;
Review comment:
This was messed up, put the class description says that `Backtrace is a
movable vector of trace lines.`, so either we should make it noncopyable, or
justify why we need to copy it and change the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
