natural commented on a change in pull request #4077: NIFI-5346 Introduces new PGP controller service and PGP processors. URL: https://github.com/apache/nifi/pull/4077#discussion_r385531663
########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/pgp/AbstractProcessorPGP.java ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.pgp; + +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.processor.AbstractProcessor; +import org.apache.nifi.processor.Relationship; + +import java.util.HashSet; +import java.util.Set; + + +/** + * Common base class for our various PGP processors. + * + * This class provides a helper for creating a {@link PropertyDescriptor} for a {@link PGPService}. The processors + * use this helper to make the property in a consistent manner. Each processor supplies a different description to + * help the user understand the way the controller is used by the processor. + * + * The set of flow relationships is the same for all four processors, so this class provides the relationship + * members and a helper method for creating their set. + * + */ +public abstract class AbstractProcessorPGP extends AbstractProcessor { + public static final String SERVICE_ID = "pgp-key-service"; + public static final String DEFAULT_SIGNATURE_ATTRIBUTE = "content-signature"; + + public static final Relationship REL_SUCCESS = new Relationship.Builder() + .name("success") + .description("Any FlowFile that is successfully encrypted or decrypted will be routed to success") + .build(); + + public static final Relationship REL_FAILURE = new Relationship.Builder() + .name("failure") + .description("Any FlowFile that cannot be encrypted or decrypted will be routed to failure") + .build(); + + /** + * Helper for subclasses to create their own PGP controller service property. + * + * @param desc {@link PropertyDescriptor} description + * @return new required {@link PropertyDescriptor} with constant name and given description + */ + static PropertyDescriptor buildControllerServiceProperty(String desc) { + return new PropertyDescriptor.Builder() + .name(SERVICE_ID) + .description(desc) + .required(true) + .identifiesControllerService(PGPService.class) + .build(); + } + + /** + * Returns the relationships for a PGP processor, one success and one failure. + * + * @return {@link Set} of processor {@link Relationship}. + */ + @Override + public Set<Relationship> getRelationships() { + HashSet<Relationship> relationships = new HashSet<>(); Review comment: That one was tricky, but I've moved it to a static initialization. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
