tpalfy commented on a change in pull request #4123: NIFI-7188: Adding filter
capabilities into search & prerequisite refactors
URL: https://github.com/apache/nifi/pull/4123#discussion_r390455730
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -147,8 +148,8 @@
// properties
private NiFiProperties properties;
private DtoFactory dtoFactory;
- private VariableRegistry variableRegistry;
private ControllerSearchService controllerSearchService;
+ private SearchQueryParser searchQueryParser;
Review comment:
As far as responsibilities go, `SearchQueryParser` seems to be something
that should be in the `ControllerSearchService` instead of the
`ControllerFacade`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
