simonbence commented on a change in pull request #4123: NIFI-7188: Adding filter capabilities into search & prerequisite refactors URL: https://github.com/apache/nifi/pull/4123#discussion_r391591983
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/search/attributematchers/ExpirationAttributeMatcher.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.search.attributematchers; + +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.connectable.Connection; +import org.apache.nifi.web.search.query.SearchQuery; + +import java.util.Arrays; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.concurrent.TimeUnit; + +public class ExpirationAttributeMatcher implements AttributeMatcher<Connection> { + private static final String MATCH_PREFIX = "FlowFile expiration: "; + private static final Set<String> KEYWORDS = new HashSet<>(Arrays.asList( // + "expires", // + "expiration")); + + @Override + public void match(final Connection component, final SearchQuery query, final List<String> matches) { + if (containsKeyword(query)) { + final int expirationMillis = component.getFlowFileQueue().getFlowFileExpiration(TimeUnit.MILLISECONDS); + + if (expirationMillis > 0) { + matches.add(MATCH_PREFIX + component.getFlowFileQueue().getFlowFileExpiration()); + } + } + } + + private boolean containsKeyword(final SearchQuery query) { + for(final String keyword : KEYWORDS) { Review comment: Looks better, I applicate it for every case like this in the matchers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
