szaszm commented on a change in pull request #746: MINIFICPP-1185 - Remove
moodycamel::concurrentqueue from threadpool
URL: https://github.com/apache/nifi-minifi-cpp/pull/746#discussion_r400043883
##########
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##########
@@ -29,11 +29,12 @@ namespace nifi {
namespace minifi {
namespace utils {
+
+// Provides a queue API and guarantees no race conditions in case of multiple
producers and consumers.
template <typename T>
class ConcurrentQueue {
public:
- ConcurrentQueue() = default;
- virtual ~ConcurrentQueue() = default;
+ explicit ConcurrentQueue() = default;
Review comment:
I don't see the need to make this explicit, although it doesn't hurt much.
It prevents code like this:
`ConcurrentQueue make_queue() { return {}; }`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
