joewitt commented on issue #4169: NIFI-7338 Adding GetSmbFile and PutSmbFile processors #2 URL: https://github.com/apache/nifi/pull/4169#issuecomment-611128345 Ok I've made it to the point that I can run GetSMbFile and pull files from a given directory and write those files back with PutSMBFile to another directory. Good. 1. It seems like 'directory' should be optional in the event we want to pull from the directory a given share is rooted at. 2. If username is set then password must be set. customValidate would be good to use here so the user knows this before attempting to run it. 3. There are no provenance events created for the SEND. There should be. See PutFile for an example. 4. The rate at which logs are spewed out is not helpful. The logs should be turned into debug at most. These are all like 'com.hierynomus.smbj.connection.Connection Successfully connected...bla' and 'com.hierynomus.smbj.session.Session ...' and 'com.hierynomus.smbj..transport.PacketReader ....bla' 5. The docs for the processor should be stronger and in particular the properties themselves.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
