bakaid commented on a change in pull request #743: Minificpp 1169 - Simplify C2
metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r406730077
##########
File path: libminifi/include/utils/BackTrace.h
##########
@@ -81,13 +83,32 @@ void pull_trace(uint8_t frames_to_skip = 1);
*/
void emplace_handler();
+class Lock {
Review comment:
Why do we need this? `std::unique_lock` would be the standard choice here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
