jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS
in Zookeeper Server
URL: https://github.com/apache/nifi/pull/4202#discussion_r407690070
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/state/server/ZooKeeperStateServer.java
##########
@@ -104,8 +105,16 @@ private void startStandalone() throws IOException {
embeddedZkServer.setMinSessionTimeout(config.getMinSessionTimeout());
embeddedZkServer.setMaxSessionTimeout(config.getMaxSessionTimeout());
+ final InetSocketAddress port = config.getClientPortAddress();
+ final InetSocketAddress secPort =
config.getSecureClientPortAddress();
connectionFactory = ServerCnxnFactory.createFactory();
- connectionFactory.configure(config.getClientPortAddress(),
config.getMaxClientCnxns());
+ if (secPort != null) {
Review comment:
Since the insecure client port and secure client port aren't mutually
exclusive you should add the checks for each port independently and setup two
connection factories with their own startup and shutdown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
