pvillard31 commented on issue #4185: URL: https://github.com/apache/nifi/pull/4185#issuecomment-616639325
It looks good to me. Could you add a unit test to confirm that catalog and schema are correctly quoted? (cc @mattyb149 to have a second pair of eyes). For the unit test, I'd duplicate ``testGeneratePreparedStatements`` and confirm that the generated statements are correctly quoted. The test is here: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/processors/standard/TestPutDatabaseRecord.groovy#L119 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
