turcsanyip commented on a change in pull request #4213:
URL: https://github.com/apache/nifi/pull/4213#discussion_r411606423
##########
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/resolver/RegexNamespaceResolver.java
##########
@@ -34,12 +34,12 @@
import java.util.regex.Pattern;
import java.util.stream.Collectors;
-public class RegexClusterResolver implements ClusterResolver {
+public class RegexNamespaceResolver implements ClusterResolver {
Review comment:
Renaming the class was a good idea. Could you please adjust the
interface name too?
##########
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/resources/docs/org.apache.nifi.atlas.reporting.ReportLineageToAtlas/additionalDetails.html
##########
@@ -275,7 +276,7 @@ <h3 id="provenance-events">NiFi Provenance Event
Analysis</h3>
</ul>
</p>
- <p>'clusterName' in 'qualifiedName' attribute is resolved by mapping
ip-address or hostname available at NiFi Provenance event 'transitUri' to a
cluster name. See <a href="cluster-name">Cluster Name Resolution</a> for
detail.</p>
+ <p>'namespace' in 'qualifiedName' attribute is resolved by mapping
ip-address or hostname available at NiFi Provenance event 'transitUri' to a
cluster name. See <a href="namespaces">Namespaces</a> for detail.</p>
Review comment:
There are still some clusterName references in the documentation below.
Eg.: `remoteOutputPortGUID@clusterName`
Could you please fix those too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
