szaszm commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r416567880
##########
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##########
@@ -99,6 +124,20 @@ class ConcurrentQueue {
return true;
}
+ template<typename Functor>
+ bool consumeImpl(std::unique_lock<std::mutex>&& lck, Functor&& fun) {
+ static_assert(std::is_nothrow_move_assignable<T>::value, "T has to be
nothrow move assignable.");
Review comment:
This is the one only doing move construction (once for initializing
`elem` and potentially a second time when moving elem to the `fun` argument)
and the other one is only doing move assignment (when assigning the element to
`out`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
