turcsanyip commented on a change in pull request #4226:
URL: https://github.com/apache/nifi/pull/4226#discussion_r417556561
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
##########
@@ -103,16 +107,10 @@
.description("The name of the shared access policy. This policy
must have Listen claims.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .required(true)
- .build();
- static final PropertyDescriptor POLICY_PRIMARY_KEY = new
PropertyDescriptor.Builder()
- .name("Shared Access Policy Primary Key")
- .description("The primary key of the shared access policy")
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .expressionLanguageSupported(ExpressionLanguageScope.NONE)
- .sensitive(true)
- .required(true)
+ .required(false)
.build();
+ static final PropertyDescriptor POLICY_PRIMARY_KEY =
AzureEventHubUtils.POLICY_PRIMARY_KEY;
+ static final PropertyDescriptor USE_MANANGED_IDENTITY =
AzureEventHubUtils.USE_MANAGED_IDENTITY;
Review comment:
@sjyang18 I cannot see this fix in your last commit. It is MANANGED in
all the 3 classes.
Please also remove the unused getConnectionString() from PutAzureEventHub
(with the import).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
