szaszm commented on a change in pull request #770:
URL: https://github.com/apache/nifi-minifi-cpp/pull/770#discussion_r428014274
##########
File path: libminifi/src/io/StreamFactory.cpp
##########
@@ -16,12 +16,13 @@
* limitations under the License.
*/
#include "io/StreamFactory.h"
+
#include <atomic>
#include <memory>
#include <mutex>
#include <string>
-#include <utils/GeneralUtils.h>
+#include <utils/GeneralUtils.h> // NOLINT
Review comment:
why do we need NOLINT here?
Also, end of line comments should have 2 preceding spaces.
##########
File path: libminifi/test/archive-tests/FocusArchiveTests.cpp
##########
@@ -16,24 +16,23 @@
* limitations under the License.
*/
+#include <algorithm>
#include <iostream>
#include <map>
+#include <memory>
#include <set>
#include <string>
-#include <algorithm>
-#include <memory>
#include <utility>
-#include "../TestBase.h"
+#include <archive.h> // NOLINT
+#include <archive_entry.h> // NOLINT
Review comment:
why do we need NOLINT here?
End of line comments should have 2 spaces before and 1 after the `//`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
