pcgrenier commented on pull request #4282: URL: https://github.com/apache/nifi/pull/4282#issuecomment-631815567
> Yeah, I think those should work fine. For something like "concat" it should work with both numbers and strings - and it does. In that case, what gets returned to calcite for the table's schema is an Object for that column, and concat will work against any type of object. > > > I also think taking this choice out of the hands of the flow developer is bad. > > I don't believe we are taking the choice out of the hands of the flow developer. We're simply saying that if you want to do some sort of numeric-only aggregate function, your schema must indicate that the field is a number. I think this is fair game. The user can, in this case, simply use a schema that indicates that field is numeric. My bad, I did test a few other string based aggregations like the LISTAGG functions and they all seem to work as intended. I just assumed if the number based functions failed on Choice returning an Object type so would the String based ones. So yeah if calcite, which it looks to be doing, is properly calling the toString on objects then yeah. This is awesome thanks for following up on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
