[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations

[GitBox]

hunyadi-dev commented on a change in pull request #789:
URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r434036993



##########
File path: libminifi/include/io/DataStream.h
##########
@@ -43,10 +43,10 @@ class DataStream {
    * Constructor
    **/
   explicit DataStream(const uint8_t *buf, const uint32_t buflen) {
-    writeData((uint8_t*) buf, buflen);
+    writeData(const_cast<uint8_t*>(reinterpret_cast<const uint8_t*>(buf)), 
buflen);

Review comment:
       My bad, `reinterpret_cast<>` removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org