hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r435404598
##########
File path: extensions/script/python/ExecutePythonProcessor.cpp
##########
@@ -35,7 +35,11 @@ namespace python {
namespace processors {
core::Property ExecutePythonProcessor::ScriptFile("Script File", // NOLINT
- R"(Path to script file to execute)", "");
+ R"(Path to script file to execute.
+ Only one of Script File or Script
Body may be used)", "");
+core::Property ExecutePythonProcessor::ScriptBody("Script Body", // NOLINT
+ R"(Script to execute.
+ Only one of Script File or Script
Body may be used)", "");
Review comment:
Checked if this pattern is recurring:
```bash
find . -name '*.cpp' | xargs grep -Hn -A2 "core::Property" | grep -v '\-\-'
| perl -p -e "s/^(.*?)[:-]([0-9]+).*$/\1 \2/g" | xargs -n2 sh -c 'perl -ne
"print "\""$1:"\"" . \$_ if $. == $2" $1' sh | grep '\"' | less | awk -F \"
'!(NF % 2)'
./extensions/script/ExecuteScript.cpp:
R"(Path to script file to execute.
./extensions/script/ExecuteScript.cpp:
Only one of Script File or Script Body may be used)", "");
./extensions/script/ExecuteScript.cpp:
R"(Body of script to execute.
./extensions/script/ExecuteScript.cpp:
Only one of Script File or Script Body may be used)", "");
./extensions/script/ExecuteScript.cpp:
R"(Comma-separated list of paths to files and/or directories which
./extensions/script/ExecuteScript.cpp:
contain modules required by the script)", "");
./extensions/script/python/ExecutePythonProcessor.cpp: R"(Path to script
file to execute.
./extensions/script/python/ExecutePythonProcessor.cpp:
Only one of Script File or Script Body may be used)", "");
./extensions/script/python/ExecutePythonProcessor.cpp: R"(Script to
execute.
./extensions/script/python/ExecutePythonProcessor.cpp:
Only one of Script File or Script Body may be used)", "");
./extensions/script/python/ExecutePythonProcessor.cpp: R"(Comma-separated
list of paths to files and/or directories which
./extensions/script/python/ExecutePythonProcessor.cpp:
contain modules required by the script)", "");
```
Seems like the only two files having this pattern is `ExecuteScript` and
`ExecutePythonProcessor.cpp`. This is probably due to the boilerplate of
`ExecutePythonProcessor` was originally copied from `ExecuteScript.cpp. Should
I remove both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
