adamdebreceni commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r440836150
########## File path: libminifi/include/utils/PropertyErrors.h ########## @@ -0,0 +1,115 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenseas/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef LIBMINIFI_INCLUDE_UTILS_PROPERTYERRORS_H_ +#define LIBMINIFI_INCLUDE_UTILS_PROPERTYERRORS_H_ + +#include <string> + +#include "Exception.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { + +namespace core { + +class PropertyValue; +class ConfigurableComponent; +class Property; + +} /* namespace core */ + +namespace utils { + +class ValueException: public Exception{ + private: + explicit ValueException(const std::string& err): Exception(ExceptionType::GENERAL_EXCEPTION, err) {} + explicit ValueException(const char* err): Exception(ExceptionType::GENERAL_EXCEPTION, err) {} + + // base class already has a virtual destructor + + friend class ParseException; + friend class ConversionException; + friend class InvalidValueException; +}; Review comment: I wanted the API as tight as possible, introducing new classes that are up for grabs is rarely beneficial, especially with the new major release coming up we should be extra careful what unremovable stuff we introduce, this clearly indicates that only we should be extending these classes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
