mattyb149 commented on a change in pull request #4350: URL: https://github.com/apache/nifi/pull/4350#discussion_r443710657
########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java ########## @@ -156,7 +162,7 @@ + "FlowFile. The 'Use statement.type Attribute' option is the only one that allows the 'SQL' statement type. If 'SQL' is specified, the value of the field specified by the " + "'Field Containing SQL' property is expected to be a valid SQL statement on the target database, and will be executed as-is.") Review comment: Also probably some text saying "please refer to the database documentation for a description of the behavior of each operation." This is because even the different DBs that `do` support "upsert" may do them differently, for instance PostgreSQL requires a unique or exclusion constraint on the update key column(s) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org