arpadboda commented on a change in pull request #784: URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444794441
########## File path: libminifi/test/script-tests/ExecutePythonProcessorTests.cpp ########## @@ -0,0 +1,220 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#define CATCH_CONFIG_MAIN + +#include <memory> +#include <string> +#include <set> + +#include "../TestBase.h" + +#include "processors/GetFile.h" +#include "python/ExecutePythonProcessor.h" +#include "processors/LogAttribute.h" +#include "processors/PutFile.h" +#include "utils/file/FileUtils.h" +#include "utils/TestUtils.h" + +namespace { +using org::apache::nifi::minifi::utils::createTempDir; +using org::apache::nifi::minifi::utils::putFileToDir; +using org::apache::nifi::minifi::utils::createTempDirWithFile; +using org::apache::nifi::minifi::utils::getFileContent; + +class ExecutePythonProcessorTestBase { + public: + ExecutePythonProcessorTestBase() : + logTestController_(LogTestController::getInstance()), + logger_(logging::LoggerFactory<org::apache::nifi::minifi::python::processors::ExecutePythonProcessor>::getLogger()) { + reInitialize(); + } + virtual ~ExecutePythonProcessorTestBase() { + logTestController_.reset(); + logTestController_.setDebug<TestPlan>(); + logTestController_.setDebug<minifi::python::processors::ExecutePythonProcessor>(); + logTestController_.setDebug<minifi::processors::PutFile>(); + logTestController_.setDebug<minifi::processors::PutFile::ReadCallback>(); + } + + protected: + void reInitialize() { + testController_.reset(new TestController()); + plan_ = testController_->createPlan(); + } + + std::string getScriptFullPath(const std::string& script_file_name) { + return SCRIPT_FILES_DIRECTORY + utils::file::FileUtils::get_separator() + script_file_name; + } + + static const std::string TEST_FILE_NAME; + static const std::string TEST_FILE_CONTENT; + static const std::string SCRIPT_FILES_DIRECTORY; + + std::unique_ptr<TestController> testController_; + std::shared_ptr<TestPlan> plan_; + LogTestController& logTestController_; + std::shared_ptr<logging::Logger> logger_; +}; + +const std::string ExecutePythonProcessorTestBase::TEST_FILE_NAME{ "test_file.txt" }; +const std::string ExecutePythonProcessorTestBase::TEST_FILE_CONTENT{ "Test text\n" }; +const std::string ExecutePythonProcessorTestBase::SCRIPT_FILES_DIRECTORY{ "test_scripts" }; + +class SimplePythonFlowFileTransferTest : public ExecutePythonProcessorTestBase { + public: + enum class Expectation { + OUTPUT_FILE_MATCHES_INPUT, + RUNTIME_RELATIONSHIP_EXCEPTION, + PROCESSOR_INITIALIZATION_EXCEPTION + }; + SimplePythonFlowFileTransferTest() : ExecutePythonProcessorTestBase{} {} + + protected: + void testSimpleFilePassthrough(const Expectation expectation, const core::Relationship& execute_python_out_conn, const std::string& used_as_script_file, const std::string& used_as_script_body) { + reInitialize(); + const std::string input_dir = createTempDirWithFile(testController_.get(), TEST_FILE_NAME, TEST_FILE_CONTENT); + const std::string output_dir = createTempDir(testController_.get()); + + addGetFileProcessorToPlan(input_dir); + if (Expectation::PROCESSOR_INITIALIZATION_EXCEPTION == expectation) { + REQUIRE_THROWS(addExecutePythonProcessorToPlan(used_as_script_file, used_as_script_body)); + return; + } + REQUIRE_NOTHROW(addExecutePythonProcessorToPlan(used_as_script_file, used_as_script_body)); + addPutFileProcessorToPlan(execute_python_out_conn, output_dir); + + plan_->runNextProcessor(); // GetFile + if (Expectation::RUNTIME_RELATIONSHIP_EXCEPTION == expectation) { + REQUIRE_THROWS(plan_->runNextProcessor()); // ExecutePythonProcessor + return; + } + REQUIRE_NOTHROW(plan_->runNextProcessor()); // ExecutePythonProcessor + plan_->runNextProcessor(); // PutFile + + const std::string output_file_path = output_dir + utils::file::FileUtils::get_separator() + TEST_FILE_NAME; + + if (Expectation::OUTPUT_FILE_MATCHES_INPUT == expectation) { + const std::string output_file_content{ getFileContent(output_file_path) }; + REQUIRE(TEST_FILE_CONTENT == output_file_content); + } + } + void testsStatefulProcessor() { + reInitialize(); + const std::string output_dir = createTempDir(testController_.get()); + + auto executePythonProcessor = plan_->addProcessor("ExecutePythonProcessor", "executePythonProcessor"); + plan_->setProperty(executePythonProcessor, org::apache::nifi::minifi::python::processors::ExecutePythonProcessor::ScriptFile.getName(), getScriptFullPath("stateful_processor.py")); + executePythonProcessor->initialize(); + + addPutFileProcessorToPlan(core::Relationship("success", "description"), output_dir); + plan_->runNextProcessor(); // ExecutePythonProcessor + for (std::size_t i = 0; i < 10; ++i) { + plan_->runCurrentProcessor(); // ExecutePythonProcessor + } + plan_->runNextProcessor(); // PutFile + for (std::size_t i = 0; i < 10; ++i) { + plan_->runCurrentProcessor(); // PutFile + const std::string state_name = std::to_string(i); + const std::string output_file_path = output_dir + utils::file::FileUtils::get_separator() + state_name; Review comment: Good shout, I'm open to it. Preferably in a follow-up ticket as it's a general util, doesn't really belong to the scope of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
