szaszm commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r446156346
########## File path: libminifi/include/utils/ValueParser.h ########## @@ -0,0 +1,183 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenseas/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef LIBMINIFI_INCLUDE_UTILS_VALUEPARSER_H_ +#define LIBMINIFI_INCLUDE_UTILS_VALUEPARSER_H_ + +#include <exception> +#include <string> +#include <cstring> +#include <vector> +#include <cstdlib> +#include <type_traits> +#include <limits> + +#include "PropertyErrors.h" +#include "GeneralUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { +namespace internal { + +class ValueParser { + private: + template<typename From, typename To, typename = void> + struct is_non_narrowing_convertible : std::false_type { + static_assert(std::is_integral<From>::value && std::is_integral<To>::value, "Checks only integral values"); + }; + + template<typename From, typename To> + struct is_non_narrowing_convertible<From, To, void_t<decltype(To{std::declval<From>()})>> : std::true_type { + static_assert(std::is_integral<From>::value && std::is_integral<To>::value, "Checks only integral values"); + }; Review comment: With the new approach, these are no longer used and can be removed. edit: That is, if you leave the new approach. It's currently failing on the CI because there is no `parse(uint64_t&)` overload ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
