turcsanyip commented on a change in pull request #4370:
URL: https://github.com/apache/nifi/pull/4370#discussion_r450673521
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
##########
@@ -321,6 +328,15 @@ public void process(final InputStream in) throws
IOException {
attributes.put(CoreAttributes.ABSOLUTE_PATH.key(), absPathString);
attributes.put(CoreAttributes.MIME_TYPE.key(),
OCTET_STREAM);
+ attributes.put(FILE_INNER_PERMISSION,
String.valueOf(tarEntry.getMode()));
Review comment:
Get/ListFile write the `file.persmissions` atrribute in "rwx" format and
PutFile can interpret it. That's why it was my first idea (for consistency).
`755` seems also fine. PutFile can handle it too.
But I don't know the other use cases so I can hardly decide between the
"rwx" vs octal format.
The current decimal value (eg. `493` for the octal `755`) should definitely
be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
