adamdebreceni commented on a change in pull request #807:
URL: https://github.com/apache/nifi-minifi-cpp/pull/807#discussion_r452134297
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -478,15 +466,9 @@ void ProcessSession::import(std::string source, const
std::shared_ptr<core::Flow
throw Exception(FILE_OPERATION_EXCEPTION, "File Import Error");
}
} catch (std::exception &exception) {
- if (flow) {
Review comment:
it previously checked if it had the claim that we just created, but an
exception can only come from before the set happens so it doesn't make much
sense to do so, IMO there should be two global `ResourceClaim`s, the
`InvalidResourceClaim` and the `EmptyResourceClaim` so we could abandon the
"empty content path signifies an empty resourceclaim" and have a non-null claim
even for these "faulty" scenarios
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
