[
https://issues.apache.org/jira/browse/OPENNLP-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280821#comment-13280821
]
Joern Kottmann commented on OPENNLP-309:
----------------------------------------
That should be fine in most cases.
If you return a POSDictionary and then change this to return a TagDictionary
you will break code.
> facilitating the specialization of POSDictionary
> ------------------------------------------------
>
> Key: OPENNLP-309
> URL: https://issues.apache.org/jira/browse/OPENNLP-309
> Project: OpenNLP
> Issue Type: Improvement
> Components: POS Tagger
> Reporter: Riccardo Tasso
> Assignee: William Colen
> Priority: Minor
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> The train method in POSTaggerME receives in input a POSDictionary. This makes
> the implementation of custom dictionaries painful.
> I suggest to replace the POSDictionary input as a TagDictionary.
> Another improvement may also be the declaration of POSDictionary fields as
> protected, to help the extension of this class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
