[ 
https://issues.apache.org/jira/browse/OPENNLP-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422630#comment-13422630
 ] 

Joern Kottmann commented on OPENNLP-527:
----------------------------------------

The component name here is "Maxent", names are a bit confusing, Maxent is the 
"old" thing we currently ship, and OpenNLP ML is the planned replacement for 
it. OpenNLP ML lives in our sandbox and is currently just a fork with some 
renaming of Maxent.
                
> No way to close FileEventStreams
> --------------------------------
>
>                 Key: OPENNLP-527
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-527
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Maxent
>    Affects Versions: maxent-3.0.2-incubating
>            Reporter: Steven Bethard
>            Assignee: Joern Kottmann
>         Attachments: FileEventStream.close.patch, FileEventStream.close.patch
>
>
> So I noticed this bug because RealValueFileEventStream.main does not close 
> the EventStream that it opens, leaving a new file open every time it is 
> called.
> I thought I could work around this by inlining the 
> RealValueFileEventStream.main code, but it turns out that 
> RealValueFileEventStream doesn't have a close method so there's nothing you 
> can do. It's superclass, FileEventStream, opens up a FileInputStream, but 
> doesn't expose that in any way.
> So, as far as I can tell, there's no way to close one of these event streams.
> I think the simplest solution would be to add a .close() method to 
> FileEventStream (and have it implement java.io.Closeable). Then 
> RealValueFileEventStream would inherit that method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to