[
https://issues.apache.org/jira/browse/OPENNLP-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452992#comment-13452992
]
Joern Kottmann commented on OPENNLP-402:
----------------------------------------
We should have a look at this issue again before we release 1.5.3.
My two main concerns are these:
- Complicated structure with all these abstract super classes and interfaces
(could easily be changed after 1.5.3)
- The language parameter is mandatory in places where it was not used before,
and does not have any meaning, e.g. while doing evaluation with sample date,
there the language from the model is used.
> CLI tools and formats refactored
> --------------------------------
>
> Key: OPENNLP-402
> URL: https://issues.apache.org/jira/browse/OPENNLP-402
> Project: OpenNLP
> Issue Type: Improvement
> Components: Command Line Interface, Formats
> Affects Versions: tools-1.5.3
> Reporter: Aliaksandr Autayeu
> Assignee: Aliaksandr Autayeu
> Labels: patch
> Fix For: tools-1.5.3
>
> Attachments: 0016-CLI-tools-and-formats-refactored.patch,
> 0017-added-direct-format-support-to-CLI-tools-and-formats.patch,
> open-nlp-cli-package.png, opennlp-cmdline-package-class-structure.png
>
>
> Proposed patch refactors CLI tools and simplifies the code by introducing
> hierarchy and removing a lot of code duplication. It also introduces better
> error and help messages, including help for formats and listing available
> formats in various tools, which are now able to work with formats directly.
> This, in turn, eliminates the need to keep converted files on disk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
