Rodrigo Agerri created OPENNLP-718:
--------------------------------------
Summary: TrainNameFinder CLI trains wiht default features if not
-factory is provided
Key: OPENNLP-718
URL: https://issues.apache.org/jira/browse/OPENNLP-718
Project: OpenNLP
Issue Type: Bug
Components: Name Finder
Affects Versions: 1.6.0
Reporter: Rodrigo Agerri
Assignee: Rodrigo Agerri
Fix For: 1.6.0
The TrainNameFinder CLI requires to provide a -factory parameter when a feature
generator is provided via the -featuregen parameter. If not -factory is
provided, at the moment of creating the TokenNameFinderFactory in the
TokenNameFinderTrainerTool class (line 207), the TokenNameFinderFactory is
created with the default TokenNameFinderFactory() constructor. That means that
the featureGenerator defaults to null and the
TokenNameFinderFactory.createContext() provides the default context generator.
I see several possible solutions:
1. Provide the TokenNameFinderFactory as a default subclass if not custom
factory is added via -factory. This way it is not compulsory to provide a
custom factory and the training process will take the feature generator
provided by -featuregen.
2. Maintain current behaviour, e.g., training with default feature generator,
but providing a warning so that the user can decide what to do.
3. Maintain current behaviour, but break with an exception advising to provide
a factory.
Maybe there are any others.
Comments?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
