[ 
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545610#comment-15545610
 ] 

Tristan Nixon commented on OPENNLP-776:
---------------------------------------

It's not about the JVM version, it's about third-party frameworks that provide 
their own serialization implementation. I use OpenNLP in Spark, which makes use 
of Kryo, which provides a more optimized serialization implementation. Kryo has 
implementations of these interfaces that are not direct sub-types of 
InputStream/OutputStream. For example, see:
https://github.com/EsotericSoftware/kryo/blob/cef15a3dc55e74162399fce163e19d4845a9f890/src/com/esotericsoftware/kryo/io/KryoObjectOutput.java

If we removed these checks, it would work with JSE's serialization, but not 
Kryo's (even though they're both running on the same JVM).

> Model Objects should be Serializable
> ------------------------------------
>
>                 Key: OPENNLP-776
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-776
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: tools-1.5.3
>            Reporter: Tristan Nixon
>            Assignee: Joern Kottmann
>            Priority: Minor
>              Labels: features, patch
>             Fix For: 1.6.1
>
>         Attachments: externalizable.patch, serializable-basemodel.patch, 
> serialization_proxy.patch
>
>
> Marking model objects (ParserModel, SentenceModel, etc.) as Serializable can 
> enable a number of features offered by other Java frameworks (my own use case 
> is described below). You've already got a good mechanism for 
> (de-)serialization, but it cannot be leveraged by other frameworks without 
> implementing the Serializable interface. I'm attaching a patch to BaseModel 
> that implements the methods in the java.io.Externalizable interface as 
> wrappers to the existing (de-)serialization methods. This simple change can 
> open up a number of useful opportunities for integrating OpenNLP with other 
> frameworks.
> My use case is that I am incorporating OpenNLP into a Spark application. This 
> requires that components of the system be distributed between the driver and 
> worker nodes within the cluster. In order to do this, Spark uses Java 
> serialization API to transmit objects between nodes. This is far more 
> efficient than instantiating models on each node independently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to