[ https://issues.apache.org/jira/browse/OPENNLP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022667#comment-16022667 ]
ASF GitHub Bot commented on OPENNLP-1076: ----------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/opennlp/pull/216 > SentenceSample should validate if spans are inside the text > ----------------------------------------------------------- > > Key: OPENNLP-1076 > URL: https://issues.apache.org/jira/browse/OPENNLP-1076 > Project: OpenNLP > Issue Type: Improvement > Components: Sentence Detector > Reporter: Joern Kottmann > Assignee: Joern Kottmann > Priority: Minor > Fix For: 1.8.1 > > > The SentenceSample should validate if the provided Spans to mark sentence > boundaries are within bounds of the provided document text. If the spans are > outside of the document text an IllegalArgumentException should be thrown to > make the code fail fast. Otherwise code which processes the SentenceSamples > will fail later and make it slightly harder to find the actual bug. -- This message was sent by Atlassian JIRA (v6.3.15#6346)