[
https://issues.apache.org/jira/browse/OPENNLP-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216232#comment-16216232
]
ASF GitHub Bot commented on OPENNLP-1149:
-----------------------------------------
kojisekig commented on issue #280: OPENNLP-1149: remove unused member in
PlainTextByLineStream and chang…
URL: https://github.com/apache/opennlp/pull/280#issuecomment-338860020
Thank you for reviewing this! I modified my patch so that we can remove if
statement by using Objects.requireNonNull() in the constructor. Please review
this again. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> remove unused member in PlainTextByLineStream
> ---------------------------------------------
>
> Key: OPENNLP-1149
> URL: https://issues.apache.org/jira/browse/OPENNLP-1149
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 1.8.2
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Fix For: 1.8.3
>
>
> PlainTextByLineStream has a private member variable "channel" but it is never
> set and hence, it is always null. It can be removed to simplify code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
