[
https://issues.apache.org/jira/browse/OPENNLP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126381#comment-17126381
]
ASF GitHub Bot commented on OPENNLP-1285:
-----------------------------------------
kinow commented on a change in pull request #377:
URL: https://github.com/apache/opennlp/pull/377#discussion_r435686123
##########
File path:
opennlp-tools/src/test/java/opennlp/tools/eval/SourceForgeModelEval.java
##########
@@ -410,7 +410,7 @@ public void evalParserModel() throws Exception {
}
}
- Assert.assertEquals(new
BigInteger("312218841713337505306598301082074515847"),
+ Assert.assertEquals(new
BigInteger("68039262350771988792233880373220954061"),
Review comment:
The change of precision in the other tests was small compared to this
one. This was the only thing that got my eye from reading the changes here.
Pretty much everything else appears to be just s/Math/StrictMath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Address failing regression tests on Java 11
> -------------------------------------------
>
> Key: OPENNLP-1285
> URL: https://issues.apache.org/jira/browse/OPENNLP-1285
> Project: OpenNLP
> Issue Type: Task
> Components: Build, Packaging and Test
> Affects Versions: 1.9.2, 1.9.3
> Reporter: Jeffrey T. Zemerick
> Assignee: Jeffrey T. Zemerick
> Priority: Major
> Attachments: java11, java8
>
>
> When executing the regression tests (mvn test
> -DOPENNLP_DATA_DIR=/path/to/opennlp-test-data/ -Peval-tests) on Java 11, a
> few tests fail:
> {quote}Failed tests:
> ArvoresDeitadasEval.evalPortugueseChunkerQn:212->chunkerCrossEval:141
> expected:<0.9648211936491359> but was:<0.9650171248355313>
> Conll02NameFinderEval.evalSpanishMiscMaxentQn:505->eval:83
> expected:<0.470219435736677> but was:<0.4733542319749216>
> Conll02NameFinderEval.evalSpanishOrganizationMaxentQn:421->eval:83
> expected:<0.682961897915169> but was:<0.67005444646098>
> ConllXPosTaggerEval.evalSwedishMaxentQn:208->eval:80
> expected:<0.9347595473833098> but was:<0.9349363507779349>
> {quote}
> Environment details:
> {quote}Apache Maven 3.6.0
> Maven home: /usr/share/maven
> Java version: 11.0.4, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.0.0-37-generic", arch: "amd64", family: "unix"
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
