[ https://issues.apache.org/jira/browse/OPENNLP-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652911#comment-17652911 ]
ASF GitHub Bot commented on OPENNLP-1414: ----------------------------------------- mawiesne opened a new pull request, #472: URL: https://github.com/apache/opennlp/pull/472 Change - - provides new JUnit test `DownloadUtilTest` to verify `DownloadUtil` - fixes an incorrect **Dutch** model URL constant (incorrect path element) - fixes an incorrect **Italian** model URL constant ("sentence" -> "tokens") - fixes an incorrect **French** model URL constant ("en-ud-ewt2 -> "fr-ud-ftb") Tasks - Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > Investigate why DownloadUtil can't retrieve NL models via CDN > ------------------------------------------------------------- > > Key: OPENNLP-1414 > URL: https://issues.apache.org/jira/browse/OPENNLP-1414 > Project: OpenNLP > Issue Type: Improvement > Affects Versions: 2.1.0 > Reporter: Martin Wiesner > Assignee: Martin Wiesner > Priority: Minor > Fix For: 2.1.1 > > > While working on OPENNLP-1413, I discovered that the class > _opennlp.tools.util.DownloadUtil_ has a runtime issue with downloading > resources (models) for the Dutch locale (nl). Other locales referenced via > the static initializer block are accessible and can be downloaded. > Moreover, a JUnit test is missing and should be provided. > {*}Aim{*}: > * Investigate what's wrong with NL resources. > * If possible, fix the problem with retrieving Dutch models. > * Provide a JUnit tests that demonstrates correct behavior for all locales. > JavaDoc is improved via OPENNLP-1413. Don't work on it twice... > {*}Note{*}: > For Dutch community this affects other parts of the Tools component as Model > classes rely on _DownloadUtil_ in at least one constructor. Therefore, this > should be fixed before the next release. -- This message was sent by Atlassian Jira (v8.20.10#820010)