[
https://issues.apache.org/jira/browse/OPENNLP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653194#comment-17653194
]
ASF GitHub Bot commented on OPENNLP-1358:
-----------------------------------------
kinow commented on code in PR #476:
URL: https://github.com/apache/opennlp/pull/476#discussion_r1059526576
##########
.github/workflows/maven.yml:
##########
@@ -23,8 +23,8 @@ jobs:
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
- os: [ubuntu-latest]
- java: [ 11 ]
+ os: [ubuntu-latest, windows-latest]
Review Comment:
I read the title of the PR and was going to suggest to enable the GH Actions
for Windows, but glad you've already enabled it! Thanks!
##########
opennlp-tools/src/test/java/opennlp/tools/AbstractTempDirTest.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+
+// Workaround for https://github.com/junit-team/junit5/issues/2811 - we cannot
use @TempDir atm.
Review Comment:
Add a `TODO`? So we don't forget?
> Failing tests on Windows 11 and Java 17
> ---------------------------------------
>
> Key: OPENNLP-1358
> URL: https://issues.apache.org/jira/browse/OPENNLP-1358
> Project: OpenNLP
> Issue Type: Task
> Affects Versions: 1.9.4
> Environment: Windows with Java 17
> Reporter: Jeff Zemerick
> Assignee: Richard Zowalla
> Priority: Minor
>
> The following tests are failing on Windows 11 and Java 17 build. The tests
> pass on Ubuntu 20.04 with Java 17.
> [ERROR] Failures:
> [ERROR] BratDocumentParserTest.testParse:55 expected:<3> but was:<1>
> [ERROR] BratDocumentTest.testDocumentWithEntitiesParsing:47
> [ERROR] BratNameSampleStreamTest.readNoOverlap:65 expected:<8> but was:<7>
> [ERROR] BratNameSampleStreamTest.readOverlapFail Expected exception:
> java.lang.RuntimeException
> [INFO]
> [ERROR] Tests run: 784, Failures: 4, Errors: 0, Skipped: 0
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\Program Files\apache-maven
> Java version: 17.0.2, vendor: Amazon.com Inc., runtime: C:\Program
> Files\Amazon Corretto\jdk17.0.2_8
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
