[
https://issues.apache.org/jira/browse/OPENNLP-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653469#comment-17653469
]
ASF GitHub Bot commented on OPENNLP-1432:
-----------------------------------------
kinow commented on code in PR #478:
URL: https://github.com/apache/opennlp/pull/478#discussion_r1059797766
##########
opennlp-tools/src/test/java/opennlp/tools/util/wordvector/GloveTest.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package opennlp.tools.util.wordvector;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+
+/*
+ * Note:
+ * Examples taken from the 'glove.6B.50d.txt' data set,
+ * which is licensed under CC0 1.0 Universal (CC0 1.0) Public Domain
Dedication.
+ * (see: https://creativecommons.org/publicdomain/zero/1.0/)
Review Comment:
Just had a read at CC0, and it doesn't require any attribution, so I think
we don't need the entry in NOTICE (as per [this asf
doc](https://www.apache.org/licenses/LICENSE-2.0.html#redistribution)). But we
can leave it open for others to comment when they review this PR too :+1:
Thanks @mawiesne !
> Provide tests for opennlp.tools.util.wordvector package
> -------------------------------------------------------
>
> Key: OPENNLP-1432
> URL: https://issues.apache.org/jira/browse/OPENNLP-1432
> Project: OpenNLP
> Issue Type: Test
> Components: Build, Packaging and Test, word vectors
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.1.1
>
>
> With OPENNLP-1144, support for word vectors was introduced. However, no JUnit
> tests were provided with that implementation.
> Aims
> * Provide tests for _opennlp.tools.util.wordvector_ package
> * Raise code coverage for the corresponding package
> * Improve JavaDoc along the way
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
