[ https://issues.apache.org/jira/browse/OPENNLP-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654031#comment-17654031 ]
ASF GitHub Bot commented on OPENNLP-1182: ----------------------------------------- atarora opened a new pull request, #482: URL: https://github.com/apache/opennlp/pull/482 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. > LanguageDetectorConverterTool is a no-op, despite the docs saying otherwise > --------------------------------------------------------------------------- > > Key: OPENNLP-1182 > URL: https://issues.apache.org/jira/browse/OPENNLP-1182 > Project: OpenNLP > Issue Type: Bug > Components: Language Detector > Affects Versions: 1.8.4 > Reporter: Steven Rowe > Assignee: Atita Arora > Priority: Minor > > Contrary to the docs (see below), LanguageDetectorConverterTool doesn't > actually do anything at all; the class is empty. > {quote} > The following sequence of commands shows how to convert the Leipzig Corpora > collection at folder leipzig-train/ to the default Language Detector format, > by creating groups of 5 sentences as documents and limiting to 10000 > documents per language. Them, it shuffles the result and select the first > 100000 lines as train corpus and the last 20000 as evaluation corpus: > {noformat} > $ bin/opennlp LanguageDetectorConverter leipzig -sentencesDir leipzig-train/ > -sentencesPerSample 5 -samplesPerLanguage 10000 > leipzig.txt > $ perl -MList::Util=shuffle -e 'print shuffle(<STDIN>);' < leipzig.txt > > leipzig_shuf.txt > $ head -100000 < leipzig_shuf.txt > leipzig.train > $ tail -20000 < leipzig_shuf.txt > leipzig.eval > {noformat} > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010)